SonarQube Code Coverage (Uncovered Conditions, Second Pass) #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to concentrate efforts in improving SonarQube's code coverage analytics. Follow-up for #141 , this is the second pass (focused
onlymostly on uncovered conditions).Here's what we have so far:
--exclude-throw-branches, which by itself upped overall coverage from 64.6% to a whopping 82.5%BUILD_BENCHMARKbeing OFF by default (so their coverage is literally 0%, as it is with thesrc/binsfiles as well) - I haven't turned them on because I don't know if that's gonna clog up the Actions workflow, but if it doesn't I would recommend doing that next just to see if percentage goes upregisterContract()lines in the headers as partially covered (specifically thestd::make_tupleinitializations, check any of them) - I have no idea why that happens, but if we somehow find out, that could also bring coverage up in a significant amount